debt(users): Make User object constructor argument mandatory#59694
Draft
artonge wants to merge 3 commits into
Draft
debt(users): Make User object constructor argument mandatory#59694artonge wants to merge 3 commits into
artonge wants to merge 3 commits into
Conversation
artonge
force-pushed
the
artonge/debt/user_args
branch
5 times, most recently
from
28062e9 to
a7d032e
Compare
artonge
force-pushed
the
artonge/debt/user_args
branch
8 times, most recently
from
43c4463 to
9b30bac
Compare
artonge
added
enhancement
2. developing
artonge
force-pushed
the
artonge/debt/user_args
branch
11 times, most recently
from
dd781af to
822edc3
Compare
artonge
force-pushed
the
artonge/debt/user_args
branch
4 times, most recently
from
0464ab3 to
22b842a
Compare
Signed-off-by: Louis Chmn <louis@chmn.me>
… User object Signed-off-by: Louis Chmn <louis@chmn.me>
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
force-pushed
the
artonge/debt/user_args
branch
from
22b842a to
22eb442
Compare
artonge
requested review from
ArtificialOwl,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
artonge
added
3. to review
artonge
added
2. developing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have a factory method to build
Userobjects, so let's use it and stop with the conditional arguments and properties. This will make adding new constructor arguments easier in the future.One nitpick is that I kept the
$backendargument optional, the reason being that in Collectives and Groupfolders, we are creating a dummy user without a backend because the files_versions API needs one.Adaptations in apps:
\OC\User\Usergroupfolders#4601\OC\User\Usercollectives#2456